Skip to content

fix: Add tests for non-pk table cdc works in append-only mode with Merge Tree#4520

Merged
masterashu merged 4 commits into
mainfrom
dbi-835-m28-no-cdc-updatedelete-coverage-for-tables-without-a
Jul 8, 2026
Merged

fix: Add tests for non-pk table cdc works in append-only mode with Merge Tree#4520
masterashu merged 4 commits into
mainfrom
dbi-835-m28-no-cdc-updatedelete-coverage-for-tables-without-a

Conversation

@masterashu

@masterashu masterashu commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • fix: Add tests for non-pk table cdc works in append-only mode with Merge Tree
  • Add validation to prevent null sharding key when setting up no-Primary Key table

@codecov

codecov Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2657 4 2653 352
View the top 3 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster
Stack Traces | 0.01s run time 
=== RUN   TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster
=== PAUSE TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster
=== CONT  TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster
--- FAIL: TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster (0.01s)

github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMySQL_CH_Cluster
Stack Traces | 0.01s run time 
=== RUN   TestPeerFlowE2ETestSuiteMySQL_CH_Cluster
=== PAUSE TestPeerFlowE2ETestSuiteMySQL_CH_Cluster
=== CONT  TestPeerFlowE2ETestSuiteMySQL_CH_Cluster
--- FAIL: TestPeerFlowE2ETestSuiteMySQL_CH_Cluster (0.01s)
2026/06/30 12:49:52 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/30 12:49:52 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/30 12:49:52 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mach_2arn0p9u.test_mysql_schema_changes

github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
Stack Traces | 61.2s run time 
=== RUN   TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
=== PAUSE TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
=== CONT  TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
2026/06/30 12:56:31 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/30 12:56:31 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_machcl_0dp0jr6n.test_nullable_sc_ch
    clickhouse_mysql_test.go:2063: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
--- FAIL: TestPeerFlowE2ETestSuiteMariaDB_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC (61.18s)

github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuiteMySQL_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
Stack Traces | 61.2s run time 
=== RUN   TestPeerFlowE2ETestSuiteMySQL_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
=== PAUSE TestPeerFlowE2ETestSuiteMySQL_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
=== CONT  TestPeerFlowE2ETestSuiteMySQL_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC
2026/06/30 12:48:51 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/30 12:48:51 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/30 12:48:51 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychcl_cdx6xlgk.test_unsigned
    clickhouse_mysql_test.go:2063: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
--- FAIL: TestPeerFlowE2ETestSuiteMySQL_CH_Cluster/Test_MySQL_NoPrimaryKey_CDC (61.18s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: The newly-added Test_MySQL_NoPrimaryKey_CDC fails deterministically across every matrix job (MySQL/MariaDB, 6.0/8.0) with "UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT", meaning the non-PK CDC mirror introduced by this PR never advances past the snapshot phase — a real bug, not flakiness.
Confidence: 0.92

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@masterashu masterashu self-assigned this Jun 30, 2026
@masterashu masterashu marked this pull request as ready for review July 1, 2026 09:35
@masterashu masterashu requested a review from a team as a code owner July 1, 2026 09:35
@claude

claude Bot commented Jul 1, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

ilidemi
ilidemi approved these changes Jul 2, 2026
View reviewed changes
Comment thread flow/e2e/clickhouse_mysql_test.go Outdated
}

if s.cluster {
// TODO: Check how this behaviour works in cluster mode.

@ilidemi ilidemi Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail on cluster or just because of the local testing? We usually test the cluster behavior in CI

@masterashu masterashu Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed for the cluster on GitHub CI too, so now with clickhouse cluster working locally, will test it out.

@masterashu masterashu requested a review from ilidemi July 6, 2026 10:15
@masterashu masterashu merged commit cf1e119 into main Jul 8, 2026
16 checks passed
@masterashu masterashu deleted the dbi-835-m28-no-cdc-updatedelete-coverage-for-tables-without-a branch July 8, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilidemi ilidemi ilidemi approved these changes

Assignees

@masterashu masterashu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masterashu @ilidemi